Changed faculty and course labels and made the course name to also show the course number #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e 'name' and 'abbreviatin' in the .py file, and added tests
…+ course number base on conditions
…into html.page with jinja.
…ify if the function works
…ulness of strings
vungc
changed the title
vungc
changed the title
BrianRamsay
requested changes
Jun 18, 2024
…ction to displayName and moved it to logic
…ction to displayName and moved it to logic
…serviceLearning and displayName
|
Modifications:
|
BrianRamsay
requested changes
Jun 25, 2024
…ed all the areas where the fucntion is used. We also changed the displayName to 'courseDisplayName'
|
@MImran2002 , is this an old PR? There are unresolved comments, still. |
WackyWeaver
reviewed
Jul 3, 2024
|
I would approve this. I ran the unit tests and checked for where there was change. It was looking great as far as I could see 👍 |
…dded to the course file
BrianRamsay
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes we made is that we created a file in models that would produce an attribute for course name and number. We also created a test for the function and tested it when both course name and number exist, when none exit and when either one of them exist. We also went to html page for slcmanagement.html and added some jinja codes. We also have to add import statements across the pages.
Fixes #1206 and #1164